stklcode/juraclient
0
0
Fork 0
Code Issues Actions Releases 21 Activity

typo fixes in comments and test messages [skip ci]

Browse Source
This commit is contained in:
Stefan Kalscheuer 2019-11-04 17:55:10 +01:00
parent 2fd8d2a87c
commit 431de69549
8 changed files with 28 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -18,7 +18,7 @@ All notable changes to this project will be documented in this file.
### Fixed ### Fixed
* Fixed issue with direction ID as `String` instead if `Integer` (#2) * Fixed issue with direction ID as `String` instead if `Integer` (#2)
* Fixed issue with vehicle ID being `null` (#3) * Fixed issue with vehicle ID being `null` (#3)
* Fixed issue with spaces in search parametes (#4) * Fixed issue with spaces in search parameters (#4)
## 1.1.3 - 2018-11-13 ## 1.1.3 - 2018-11-13

2
README.md
View File

@ -17,7 +17,7 @@ local bus station or any other custom queries. API versions 1.x and 2.x are supp
// Instantiate the client (e.g. using the TFL API) // Instantiate the client (e.g. using the TFL API)
UraClient ura = new UraClient("http://countdown.api.tfl.gov.uk"); UraClient ura = new UraClient("http://countdown.api.tfl.gov.uk");
// Initiailize the API with non-standard endpoints (e.g. ASEAG with API V2) // Initialize the API with non-standard endpoints (e.g. ASEAG with API V2)
UraClient ura = new UraClient("http://ivu.aseag.de", UraClient ura = new UraClient("http://ivu.aseag.de",
"interfaces/ura/instant_V2", "interfaces/ura/instant_V2",
"interfaces/ura/stream_V2"); "interfaces/ura/stream_V2");

2
src/main/java/de/stklcode/pubtrans/ura/UraClient.java
View File

@ -367,7 +367,7 @@ public class UraClient implements Serializable {
* *
* @param url The URL. * @param url The URL.
* @return Input Stream of results. * @return Input Stream of results.
* @throws IOException Error opening conneciton or reading data. * @throws IOException Error opening connection or reading data.
*/ */
private InputStream request(String url) throws IOException { private InputStream request(String url) throws IOException {
return new URL(url).openStream(); return new URL(url).openStream();

2
src/main/java/de/stklcode/pubtrans/ura/model/Trip.java
View File

@ -145,7 +145,7 @@ public final class Trip implements Model {
} }
/** /**
* Construct Stop object from raw list of attributes parsed from JSON with explicitly specified version. * Construct Trip object from raw list of attributes parsed from JSON with explicitly specified version.
* *
* @param raw List of attributes from JSON line * @param raw List of attributes from JSON line
* @param version API version * @param version API version

4
src/main/java/de/stklcode/pubtrans/ura/reader/AsyncUraTripReader.java
View File

@ -70,7 +70,7 @@ public class AsyncUraTripReader implements AutoCloseable {
} }
public void open() { public void open() {
// Throw exeption, if future is already present. // Throw exception, if future is already present.
if (future != null) { if (future != null) {
throw new IllegalStateException("Reader already opened"); throw new IllegalStateException("Reader already opened");
} }
@ -113,7 +113,7 @@ public class AsyncUraTripReader implements AutoCloseable {
/** /**
* Close the reader. * Close the reader.
* This is done by signaliung cancel to the asyncronous task. If the task is not completed * This is done by signaling cancel to the asynchronous task. If the task is not completed
* within 1 second however it is cancelled hard. * within 1 second however it is cancelled hard.
*/ */
@Override @Override

16
src/test/java/de/stklcode/pubtrans/ura/model/StopTest.java
View File

@ -29,7 +29,7 @@ import static org.hamcrest.core.Is.is;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
/** /**
* Unit test for the Stop metamodel. * Unit test for the {@link Stop} meta model.
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
@ -85,7 +85,7 @@ public class StopTest {
invalid.add(1, 5); invalid.add(1, 5);
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with invalid name field successfull"); fail("Creation of Stop with invalid name field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -95,7 +95,7 @@ public class StopTest {
invalid.add(2, 0); invalid.add(2, 0);
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with invalid id field successfull"); fail("Creation of Stop with invalid id field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -105,7 +105,7 @@ public class StopTest {
invalid.add(3, -1.23); invalid.add(3, -1.23);
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with invalid indicator field successfull"); fail("Creation of Stop with invalid indicator field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -115,7 +115,7 @@ public class StopTest {
invalid.add(4, "foo"); invalid.add(4, "foo");
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with invalid state field successfull"); fail("Creation of Stop with invalid state field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -125,7 +125,7 @@ public class StopTest {
invalid.add(5, "123"); invalid.add(5, "123");
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with invalid latitude field successfull"); fail("Creation of Stop with invalid latitude field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -135,7 +135,7 @@ public class StopTest {
invalid.add(6, 456); invalid.add(6, 456);
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with invalid longitude field successfull"); fail("Creation of Stop with invalid longitude field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -144,7 +144,7 @@ public class StopTest {
invalid.remove(6); invalid.remove(6);
try { try {
new Stop(invalid); new Stop(invalid);
fail("Creation of Stop with too short list successfull"); fail("Creation of Stop with too short list successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }

24
src/test/java/de/stklcode/pubtrans/ura/model/TripTest.java
View File

@ -29,7 +29,7 @@ import static org.hamcrest.core.Is.is;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
/** /**
* Unit test for the Trip metamodel. * Unit test for the {@link Trip} meta model.
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
@ -156,7 +156,7 @@ public class TripTest {
invalid.add(7, "123"); invalid.add(7, "123");
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid visitID field successfull"); fail("Creation of Trip with invalid visitID field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -166,7 +166,7 @@ public class TripTest {
invalid.add(8, 25); invalid.add(8, 25);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid lineID field successfull"); fail("Creation of Trip with invalid lineID field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -176,7 +176,7 @@ public class TripTest {
invalid.add(9, 234L); invalid.add(9, 234L);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid line name field successfull"); fail("Creation of Trip with invalid line name field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -186,7 +186,7 @@ public class TripTest {
invalid.add(10, "7"); // Strings are generally OK, but 7 is out of range (#2). invalid.add(10, "7"); // Strings are generally OK, but 7 is out of range (#2).
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid directionID field successfull"); fail("Creation of Trip with invalid directionID field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -196,7 +196,7 @@ public class TripTest {
invalid.add(11, 987); invalid.add(11, 987);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid destinationName field successfull"); fail("Creation of Trip with invalid destinationName field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -206,7 +206,7 @@ public class TripTest {
invalid.add(12, 456.78); invalid.add(12, 456.78);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid destinationText field successfull"); fail("Creation of Trip with invalid destinationText field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -216,7 +216,7 @@ public class TripTest {
invalid.add(13, 'x'); invalid.add(13, 'x');
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid vehicleID field successfull"); fail("Creation of Trip with invalid vehicleID field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -226,7 +226,7 @@ public class TripTest {
invalid.add(14, 1.2); invalid.add(14, 1.2);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid id field successfull"); fail("Creation of Trip with invalid id field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -236,7 +236,7 @@ public class TripTest {
invalid.add(15, 456); invalid.add(15, 456);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with invalid estimatedTime field successfull"); fail("Creation of Trip with invalid estimatedTime field successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -245,7 +245,7 @@ public class TripTest {
invalid.remove(15); invalid.remove(15);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with too short list successfull"); fail("Creation of Trip with too short list successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }
@ -254,7 +254,7 @@ public class TripTest {
invalid.set(10, 3); invalid.set(10, 3);
try { try {
new Trip(invalid); new Trip(invalid);
fail("Creation of Trip with direction ID 3 successfull"); fail("Creation of Trip with direction ID 3 successful");
} catch (Exception e) { } catch (Exception e) {
assertThat(e, is(instanceOf(IOException.class))); assertThat(e, is(instanceOf(IOException.class)));
} }

4
src/test/java/de/stklcode/pubtrans/ura/reader/AsyncUraTripReaderTest.java
View File

@ -92,7 +92,7 @@ public class AsyncUraTripReaderTest {
) )
); );
// Open the rewader. // Open the reader.
tr.open(); tr.open();
// Read for 1 second. // Read for 1 second.
TimeUnit.SECONDS.sleep(1); TimeUnit.SECONDS.sleep(1);
@ -253,7 +253,7 @@ public class AsyncUraTripReaderTest {
* Write next line from the buffer to the mocked stream pipe. * Write next line from the buffer to the mocked stream pipe.
* *
* @return {@code true} if a line has been written. * @return {@code true} if a line has been written.
* @throws IOException Errir writing the data. * @throws IOException Error writing the data.
*/ */
private static boolean writeNextLine() throws IOException { private static boolean writeNextLine() throws IOException {
String line = MOCK_LINES.poll(); String line = MOCK_LINES.poll();