24 Commits

Author SHA1 Message Date
be57a7a789 release: prepare release 2.0.8
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/tag Build is passing
2024-10-03 18:42:42 +02:00
6d3069b34a docs: update badges in README.md
Some checks reported errors
continuous-integration/drone/push Build was killed
2024-10-03 18:41:23 +02:00
30f62795eb build: migrate maven central deployment to publishing api
All checks were successful
continuous-integration/drone/push Build is passing
2024-10-03 18:31:58 +02:00
6d091fd047 build: update maven plugins
All checks were successful
continuous-integration/drone/push Build is passing
2024-10-03 18:08:35 +02:00
8312a0f358 deps: update junit-jupiter to 5.11.1 2024-10-03 18:07:02 +02:00
1e7ee35421 deps: update jackson-databind to 2.18.0 2024-10-03 18:06:17 +02:00
7bd4dd7e78 chore: update license headers
All checks were successful
continuous-integration/drone/push Build is passing
2024-09-16 18:47:12 +02:00
404981c659 build: remove Automatic-Module-Name from JAR manifest
All checks were successful
continuous-integration/drone/push Build is passing
We do provide a module-info already, so we should remove ths artifact
from the Java 8 days.
2024-09-16 18:44:13 +02:00
780c3238ff deps: update jackson-databind to 2.17.2
All checks were successful
continuous-integration/drone/push Build is passing
2024-09-16 18:35:27 +02:00
66803f5867 deps: update build and test dependencies 2024-09-16 18:33:20 +02:00
cde128cf92 release: prepare release 2.0.7
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/tag Build is passing
2024-06-29 13:58:11 +02:00
50e98353ef fix: rename getStreeamPath to getStreamPath
All checks were successful
continuous-integration/drone/push Build is passing
2024-06-29 13:50:39 +02:00
ff2650e8c1 test: minor test code refactoring 2024-06-29 13:48:29 +02:00
14f4266cb1 build: generate and attach CycloneDX SBOM 2024-06-29 13:35:10 +02:00
65895d4167 deps: update build and test dependencies 2024-06-29 13:33:00 +02:00
ae2093b9fc docs: fix some typos on javadocs
All checks were successful
continuous-integration/drone/push Build is passing
2024-05-07 18:50:58 +02:00
47f9ad86db deps: update jackson to 2.17.1
All checks were successful
continuous-integration/drone/push Build is passing
2024-05-07 18:48:42 +02:00
c2af3a911d docs: add changelog for v2.0.6
Some checks reported errors
continuous-integration/drone/push Build is passing
continuous-integration/drone/tag Build was killed
2024-03-23 18:26:20 +01:00
6f7109f527 docs: mark v1.x as no longer supported
All checks were successful
continuous-integration/drone/push Build is passing
2024-03-23 18:25:01 +01:00
21484e2e0b ci: update GitHub actions
All checks were successful
continuous-integration/drone/push Build is passing
2024-03-23 18:20:47 +01:00
72fbbdf91b ci: run sonar analysis with JDK 21
All checks were successful
continuous-integration/drone/push Build is passing
2024-03-23 18:06:50 +01:00
38d866aaac deps: update maven plugins and test dependencies
All checks were successful
continuous-integration/drone/push Build is passing
2024-03-23 17:58:34 +01:00
8ee9ccb9c9 deps: update jackson to 2.17.0 2024-03-23 17:58:23 +01:00
b99d3099ee build and test with JDK 21
All checks were successful
continuous-integration/drone/push Build is passing
2023-10-15 17:23:12 +02:00
25 changed files with 213 additions and 105 deletions

View File

@ -22,10 +22,10 @@ steps:
--- ---
kind: pipeline kind: pipeline
type: docker type: docker
name: java20 name: java21
steps: steps:
- name: test - name: test
image: maven:3-eclipse-temurin-20 image: maven:3-eclipse-temurin-21
commands: commands:
- mvn -B clean test - mvn -B clean test

View File

@ -5,17 +5,17 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
strategy: strategy:
matrix: matrix:
jdk: [ 11, 17, 20 ] jdk: [ 11, 17, 21 ]
include: include:
- jdk: 11 - jdk: 21
analysis: true analysis: true
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@v3 uses: actions/checkout@v4
with: with:
fetch-depth: 0 fetch-depth: 0
- name: Set up Java - name: Set up Java
uses: actions/setup-java@v3 uses: actions/setup-java@v4
with: with:
java-version: ${{ matrix.jdk }} java-version: ${{ matrix.jdk }}
distribution: 'temurin' distribution: 'temurin'

View File

@ -1,6 +1,35 @@
# Changelog # Changelog
All notable changes to this project will be documented in this file. All notable changes to this project will be documented in this file.
## 2.0.8 - 2024-10-03
### Fixed
* Remove `Automatic-Module-Name` from JAR manifest
### Dependencies
* Updated Jackson dependency to 2.18.0
## 2.0.7 - 2024-06-29
### Fixed
* renamed `UraClientConfiguration#getStreeamPath()` to `getStreamPath()`
### Dependencies
* Updated Jackson dependency to 2.17.1
### Improvement
* Generate and attach CycloneDX SBOM
## 2.0.6 - 2024-03-23
### Dependencies
* Updated Jackson dependency to 2.17.0
### Misc
* Tested with JDK 21
## 2.0.5 - 2023-10-03 ## 2.0.5 - 2023-10-03
### Dependencies ### Dependencies
* Updated Jackson dependency to 2.15.2 * Updated Jackson dependency to 2.15.2
@ -55,6 +84,14 @@ All notable changes to this project will be documented in this file.
---- ----
## 1.3.3 - 2022-11-21
### Security
* Updated Jackson dependency to 2.14.0
### Fixed
* Querying trips and messages with limit directly from `Query` instance (#19)
## 1.3.2 - 2022-08-30 ## 1.3.2 - 2022-08-30
### Improvements ### Improvements

View File

@ -1,8 +1,8 @@
# jURAclient # jURAclient
[![Build Status](https://github.com/stklcode/juraclient/actions/workflows/ci.yml/badge.svg)](https://github.com/stklcode/juraclient/actions/workflows/ci.yml) [![CI](https://github.com/stklcode/juraclient/actions/workflows/ci.yml/badge.svg)](https://github.com/stklcode/juraclient/actions/workflows/ci.yml)
[![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=de.stklcode.pubtrans%3Ajuraclient&metric=alert_status)](https://sonarcloud.io/dashboard?id=de.stklcode.pubtrans%3Ajuraclient) [![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=de.stklcode.pubtrans%3Ajuraclient&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=de.stklcode.pubtrans%3Ajuraclient)
[![Javadocs](https://www.javadoc.io/badge/de.stklcode.pubtrans/juraclient.svg)](https://www.javadoc.io/doc/de.stklcode.pubtrans/juraclient) [![Javadocs](https://www.javadoc.io/badge/de.stklcode.pubtrans/juraclient.svg)](https://www.javadoc.io/doc/de.stklcode.pubtrans/juraclient)
[![Maven Central](https://img.shields.io/maven-central/v/de.stklcode.pubtrans/juraclient.svg)](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22de.stklcode.pubtrans%22%20AND%20a%3A%22juraclient%22) [![Maven Central Version](https://img.shields.io/maven-central/v/de.stklcode.pubtrans/juraclient.svg)](https://central.sonatype.com/artifact/de.stklcode.pubtrans/juraclient)
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/stklcode/juraclient/blob/master/LICENSE.txt) [![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/stklcode/juraclient/blob/master/LICENSE.txt)
Java client for URA based public transport APIs. Java client for URA based public transport APIs.
@ -15,8 +15,7 @@ Version 2.x requires Java 11 or later.
It also contains some new features and allows configuration using a dedicated configuration object. It also contains some new features and allows configuration using a dedicated configuration object.
Version 1.x requires Java 8 or later. Version 1.x requires Java 8 or later.
This version currently receives security and bugfix updates. This version is no longer supported and will not receive any future updates.
However, new features might not be backported.
## Usage Examples ## Usage Examples
@ -81,7 +80,7 @@ List<Message> msgs = ura.forStops("100000")
<dependency> <dependency>
<groupId>de.stklcode.pubtrans</groupId> <groupId>de.stklcode.pubtrans</groupId>
<artifactId>juraclient</artifactId> <artifactId>juraclient</artifactId>
<version>2.0.5</version> <version>2.0.8</version>
</dependency> </dependency>
``` ```

78
pom.xml
View File

@ -6,7 +6,7 @@
<groupId>de.stklcode.pubtrans</groupId> <groupId>de.stklcode.pubtrans</groupId>
<artifactId>juraclient</artifactId> <artifactId>juraclient</artifactId>
<version>2.0.5</version> <version>2.0.8</version>
<properties> <properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@ -50,25 +50,25 @@
<dependency> <dependency>
<groupId>com.fasterxml.jackson.core</groupId> <groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId> <artifactId>jackson-databind</artifactId>
<version>2.15.2</version> <version>2.18.0</version>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.junit.jupiter</groupId> <groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId> <artifactId>junit-jupiter</artifactId>
<version>5.10.0</version> <version>5.11.1</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.hamcrest</groupId> <groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId> <artifactId>hamcrest</artifactId>
<version>2.2</version> <version>3.0</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.wiremock</groupId> <groupId>org.wiremock</groupId>
<artifactId>wiremock</artifactId> <artifactId>wiremock</artifactId>
<version>3.2.0</version> <version>3.9.1</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
@ -78,7 +78,7 @@
<dependency> <dependency>
<groupId>org.sonarsource.scanner.maven</groupId> <groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId> <artifactId>sonar-maven-plugin</artifactId>
<version>3.10.0.2594</version> <version>4.0.0.4121</version>
</dependency> </dependency>
</dependencies> </dependencies>
</dependencyManagement> </dependencyManagement>
@ -88,7 +88,7 @@
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId> <artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version> <version>3.13.0</version>
<configuration> <configuration>
<release>11</release> <release>11</release>
<source>11</source> <source>11</source>
@ -98,23 +98,20 @@
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId> <artifactId>maven-jar-plugin</artifactId>
<version>3.3.0</version> <version>3.4.2</version>
<configuration> <configuration>
<archive> <archive>
<manifest> <manifest>
<addClasspath>true</addClasspath> <addClasspath>true</addClasspath>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest> </manifest>
<manifestEntries>
<Automatic-Module-Name>de.stklcode.pubtrans.juraclient</Automatic-Module-Name>
</manifestEntries>
</archive> </archive>
</configuration> </configuration>
</plugin> </plugin>
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId> <artifactId>maven-surefire-plugin</artifactId>
<version>3.1.2</version> <version>3.5.0</version>
</plugin> </plugin>
</plugins> </plugins>
</build> </build>
@ -127,7 +124,7 @@
<plugin> <plugin>
<groupId>org.jacoco</groupId> <groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId> <artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.10</version> <version>0.8.12</version>
<executions> <executions>
<execution> <execution>
<id>prepare-agent</id> <id>prepare-agent</id>
@ -158,7 +155,7 @@
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId> <artifactId>maven-source-plugin</artifactId>
<version>3.3.0</version> <version>3.3.1</version>
<executions> <executions>
<execution> <execution>
<id>attach-sources</id> <id>attach-sources</id>
@ -182,7 +179,7 @@
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId> <artifactId>maven-javadoc-plugin</artifactId>
<version>3.6.0</version> <version>3.10.1</version>
<configuration> <configuration>
<overview>${basedir}/src/main/javadoc/overview.html</overview> <overview>${basedir}/src/main/javadoc/overview.html</overview>
<source>11</source> <source>11</source>
@ -200,6 +197,30 @@
</build> </build>
</profile> </profile>
<profile>
<id>sbom</id>
<build>
<plugins>
<plugin>
<groupId>org.cyclonedx</groupId>
<artifactId>cyclonedx-maven-plugin</artifactId>
<version>2.8.2</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>makeBom</goal>
</goals>
<configuration>
<skipNotDeployed>false</skipNotDeployed>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile> <profile>
<id>sign</id> <id>sign</id>
<build> <build>
@ -207,7 +228,7 @@
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId> <artifactId>maven-gpg-plugin</artifactId>
<version>3.1.0</version> <version>3.2.7</version>
<executions> <executions>
<execution> <execution>
<id>sign-artifacts</id> <id>sign-artifacts</id>
@ -240,17 +261,20 @@
</profile> </profile>
<profile> <profile>
<id>sonatype</id> <id>central</id>
<distributionManagement> <build>
<repository> <plugins>
<id>ossrh</id> <plugin>
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url> <groupId>org.sonatype.central</groupId>
</repository> <artifactId>central-publishing-maven-plugin</artifactId>
<snapshotRepository> <version>0.6.0</version>
<id>ossrh</id> <extensions>true</extensions>
<url>https://oss.sonatype.org/content/repositories/snapshots</url> <configuration>
</snapshotRepository> <publishingServerId>central</publishingServerId>
</distributionManagement> </configuration>
</plugin>
</plugins>
</build>
</profile> </profile>
</profiles> </profiles>
</project> </project>

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -314,7 +314,7 @@ public class UraClient implements Serializable {
// Create the reader. // Create the reader.
try { try {
AsyncUraTripReader reader = new AsyncUraTripReader( AsyncUraTripReader reader = new AsyncUraTripReader(
URI.create(requestURL(config.getBaseURL() + config.getStreeamPath(), REQUEST_TRIP, query)), URI.create(requestURL(config.getBaseURL() + config.getStreamPath(), REQUEST_TRIP, query)),
config, config,
consumers consumers
); );

View File

@ -1,3 +1,19 @@
/*
* Copyright 2016-2024 Stefan Kalscheuer
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package de.stklcode.pubtrans.ura; package de.stklcode.pubtrans.ura;
import java.io.Serializable; import java.io.Serializable;
@ -87,7 +103,7 @@ public class UraClientConfiguration implements Serializable {
* *
* @return Stream endpoint path. * @return Stream endpoint path.
*/ */
public String getStreeamPath() { public String getStreamPath() {
return this.streamPath; return this.streamPath;
} }

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,3 +1,19 @@
/*
* Copyright 2016-2024 Stefan Kalscheuer
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package de.stklcode.pubtrans.ura.model; package de.stklcode.pubtrans.ura.model;
import java.io.IOException; import java.io.IOException;
@ -187,7 +203,7 @@ public class Message implements Model {
/** /**
* Messages are assigned a priority in order for them to be ranked. * Messages are assigned a priority in order for them to be ranked.
* Since it is possible for a stop to be assigned multiple messages it is important to ensure priority is given. * Since it is possible for a stop to be assigned multiple messages it is important to ensure priority is given.
* Priorities are between 1 and 10 (where 1 is the highest priority). By default the message priority is set to 3. * Priorities are between 1 and 10 (where 1 is the highest priority). By default, the message priority is set to 3.
* *
* @return Message priority. * @return Message priority.
*/ */

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -196,7 +196,7 @@ public final class Stop implements Model {
} }
/** /**
* The longitude of the stop. This isexpressed using the WGS84 coordinate system. * The longitude of the stop. This is expressed using the WGS84 coordinate system.
* *
* @return The stop geolocation longitude. * @return The stop geolocation longitude.
*/ */

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.

View File

@ -1,3 +1,19 @@
/*
* Copyright 2016-2024 Stefan Kalscheuer
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package de.stklcode.pubtrans.ura; package de.stklcode.pubtrans.ura;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -12,9 +28,9 @@ import static org.junit.jupiter.api.Assertions.assertNull;
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
public class UraClientConfigurationTest { class UraClientConfigurationTest {
@Test @Test
public void configBuilderTest() { void configBuilderTest() {
final String baseURL = "https://ura.example.com"; final String baseURL = "https://ura.example.com";
final String instantPath = "/path/to/instant"; final String instantPath = "/path/to/instant";
final String streamPath = "/path/to/stream"; final String streamPath = "/path/to/stream";
@ -25,7 +41,7 @@ public class UraClientConfigurationTest {
UraClientConfiguration config = UraClientConfiguration.forBaseURL(baseURL).build(); UraClientConfiguration config = UraClientConfiguration.forBaseURL(baseURL).build();
assertEquals(baseURL, config.getBaseURL(), "Unexpected base URL"); assertEquals(baseURL, config.getBaseURL(), "Unexpected base URL");
assertEquals("/interfaces/ura/instant_V1", config.getInstantPath(), "Unexpected default instant path"); assertEquals("/interfaces/ura/instant_V1", config.getInstantPath(), "Unexpected default instant path");
assertEquals("/interfaces/ura/stream_V1", config.getStreeamPath(), "Unexpected default stream path"); assertEquals("/interfaces/ura/stream_V1", config.getStreamPath(), "Unexpected default stream path");
assertNull(config.getConnectTimeout(), "No default connection timeout expected"); assertNull(config.getConnectTimeout(), "No default connection timeout expected");
assertNull(config.getTimeout(), "No default timeout expected"); assertNull(config.getTimeout(), "No default timeout expected");
@ -36,7 +52,7 @@ public class UraClientConfigurationTest {
.build(); .build();
assertEquals(baseURL, config.getBaseURL(), "Unexpected base URL"); assertEquals(baseURL, config.getBaseURL(), "Unexpected base URL");
assertEquals(instantPath, config.getInstantPath(), "Unexpected custom instant path"); assertEquals(instantPath, config.getInstantPath(), "Unexpected custom instant path");
assertEquals(streamPath, config.getStreeamPath(), "Unexpected custom stream path"); assertEquals(streamPath, config.getStreamPath(), "Unexpected custom stream path");
// With timeouts. (#14) // With timeouts. (#14)
config = UraClientConfiguration.forBaseURL(baseURL) config = UraClientConfiguration.forBaseURL(baseURL)

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -45,19 +45,19 @@ import static org.junit.jupiter.api.Assertions.*;
/** /**
* Unit test for the URA Client. * Unit test for the URA Client.
* Tests run against mocked data collected from ASEAG API (no longer available) and * Tests run against mocked data collected from ASEAG API (no longer available) and
* TFL API (http://countdown.api.tfl.gov.uk) * TFL API (<a href="https://countdown.api.tfl.gov.uk">https://countdown.api.tfl.gov.uk</a>)
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
public class UraClientTest { class UraClientTest {
@RegisterExtension @RegisterExtension
public static WireMockExtension wireMock = WireMockExtension.newInstance() static WireMockExtension wireMock = WireMockExtension.newInstance()
.options(wireMockConfig().dynamicPort()) .options(wireMockConfig().dynamicPort())
.build(); .build();
@Test @Test
public void getStopsTest() throws UraClientException { void getStopsTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(2, "instant_V2_stops.txt"); mockHttpToFile(2, "instant_V2_stops.txt");
@ -83,7 +83,7 @@ public class UraClientTest {
} }
@Test @Test
public void getStopsForLineTest() throws UraClientException { void getStopsForLineTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(2, "instant_V2_stops_line.txt"); mockHttpToFile(2, "instant_V2_stops_line.txt");
@ -101,7 +101,7 @@ public class UraClientTest {
} }
@Test @Test
public void getStopsForPositionTest() throws UraClientException { void getStopsForPositionTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_stops_circle.txt"); mockHttpToFile(1, "instant_V1_stops_circle.txt");
@ -127,7 +127,7 @@ public class UraClientTest {
} }
@Test @Test
public void getTripsForDestinationNamesTest() throws UraClientException { void getTripsForDestinationNamesTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_trips_destination.txt"); mockHttpToFile(1, "instant_V1_trips_destination.txt");
@ -150,7 +150,7 @@ public class UraClientTest {
} }
@Test @Test
public void getTripsTowardsTest() throws UraClientException { void getTripsTowardsTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_trips_towards.txt"); mockHttpToFile(1, "instant_V1_trips_towards.txt");
@ -165,7 +165,7 @@ public class UraClientTest {
} }
@Test @Test
public void getTripsTest() throws UraClientException { void getTripsTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_trips_all.txt"); mockHttpToFile(1, "instant_V1_trips_all.txt");
@ -229,11 +229,11 @@ public class UraClientTest {
"Expected reader to raise an exception" "Expected reader to raise an exception"
); );
assertEquals("Failed to read trips from API", exception.getMessage(), "Unexpected error message"); assertEquals("Failed to read trips from API", exception.getMessage(), "Unexpected error message");
assertTrue(exception.getCause() instanceof IOException, "Unexpected error cause"); assertInstanceOf(IOException.class, exception.getCause(), "Unexpected error cause");
} }
@Test @Test
public void getTripsForStopTest() throws UraClientException { void getTripsForStopTest() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_trips_stop.txt"); mockHttpToFile(1, "instant_V1_trips_stop.txt");
@ -274,11 +274,11 @@ public class UraClientTest {
"Expected reader to raise an exception" "Expected reader to raise an exception"
); );
assertEquals("Failed to read stops from API", exception.getMessage(), "Unexpected error message"); assertEquals("Failed to read stops from API", exception.getMessage(), "Unexpected error message");
assertTrue(exception.getCause() instanceof IOException, "Unexpected error cause"); assertInstanceOf(IOException.class, exception.getCause(), "Unexpected error cause");
} }
@Test @Test
public void getTripsForLine() throws UraClientException { void getTripsForLine() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_trips_line.txt"); mockHttpToFile(1, "instant_V1_trips_line.txt");
@ -327,7 +327,7 @@ public class UraClientTest {
} }
@Test @Test
public void getTripsForStopAndLine() throws UraClientException { void getTripsForStopAndLine() throws UraClientException {
// Mock the HTTP call. // Mock the HTTP call.
mockHttpToFile(1, "instant_V1_trips_stop_line.txt"); mockHttpToFile(1, "instant_V1_trips_stop_line.txt");
@ -348,7 +348,7 @@ public class UraClientTest {
@Test @Test
public void getMessages() throws UraClientException { void getMessages() throws UraClientException {
UraClient uraClient = new UraClient(wireMock.baseUrl()); UraClient uraClient = new UraClient(wireMock.baseUrl());
// Mock the HTTP call. // Mock the HTTP call.
@ -379,11 +379,11 @@ public class UraClientTest {
"Expected reader to raise an exception" "Expected reader to raise an exception"
); );
assertEquals("Failed to read messages from API", exception.getMessage(), "Unexpected error message"); assertEquals("Failed to read messages from API", exception.getMessage(), "Unexpected error message");
assertTrue(exception.getCause() instanceof IOException, "Unexpected error cause"); assertInstanceOf(IOException.class, exception.getCause(), "Unexpected error cause");
} }
@Test @Test
public void getMessagesForStop() throws UraClientException { void getMessagesForStop() throws UraClientException {
UraClient uraClient = new UraClient(wireMock.baseUrl(), "/interfaces/ura/instant_V2", "/interfaces/ura/stream"); UraClient uraClient = new UraClient(wireMock.baseUrl(), "/interfaces/ura/instant_V2", "/interfaces/ura/stream");
// Mock the HTTP call. // Mock the HTTP call.
@ -406,7 +406,7 @@ public class UraClientTest {
} }
@Test @Test
public void timeoutTest() { void timeoutTest() {
// Try to read trips from TEST-NET-1 IP that is not routed (hopefully) and will not connect within 100ms. // Try to read trips from TEST-NET-1 IP that is not routed (hopefully) and will not connect within 100ms.
UraClientException exception = assertThrows( UraClientException exception = assertThrows(
UraClientException.class, UraClientException.class,
@ -417,7 +417,7 @@ public class UraClientTest {
).forDestinationNames("Piccadilly Circus").getTrips(), ).forDestinationNames("Piccadilly Circus").getTrips(),
"Connection to TEST-NET-1 address should fail" "Connection to TEST-NET-1 address should fail"
); );
assertTrue(exception.getCause() instanceof HttpConnectTimeoutException, "Exception cause is not HttpConnectionTimeoutException"); assertInstanceOf(HttpConnectTimeoutException.class, exception.getCause(), "Exception cause is not HttpConnectionTimeoutException");
// Mock the HTTP call with delay of 200ms, but immediate connection. // Mock the HTTP call with delay of 200ms, but immediate connection.
wireMock.stubFor( wireMock.stubFor(
@ -444,7 +444,7 @@ public class UraClientTest {
).forDestinationNames("Piccadilly Circus").getTrips(), ).forDestinationNames("Piccadilly Circus").getTrips(),
"Response timeout did not raise an exception" "Response timeout did not raise an exception"
); );
assertTrue(exception.getCause() instanceof HttpTimeoutException, "Exception cause is not HttpTimeoutException"); assertInstanceOf(HttpTimeoutException.class, exception.getCause(), "Exception cause is not HttpTimeoutException");
assertDoesNotThrow( assertDoesNotThrow(
() -> new UraClient( () -> new UraClient(

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -30,13 +30,13 @@ import static org.hamcrest.core.Is.is;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
/** /**
* Unit test for the {@link Message} meta model. * Unit test for the {@link Message} model.
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
public class MessageTest { class MessageTest {
@Test @Test
public void basicConstructorTest() { void basicConstructorTest() {
Message message = new Message("sid", Message message = new Message("sid",
"name", "name",
"indicator", "indicator",
@ -60,7 +60,7 @@ public class MessageTest {
} }
@Test @Test
public void listConstructorTest() { void listConstructorTest() {
/* Create valid raw data list */ /* Create valid raw data list */
List<Serializable> raw = new ArrayList<>(); List<Serializable> raw = new ArrayList<>();
raw.add(1); raw.add(1);

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -30,13 +30,13 @@ import static org.hamcrest.core.Is.is;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
/** /**
* Unit test for the {@link Stop} meta model. * Unit test for the {@link Stop} model.
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
public class StopTest { class StopTest {
@Test @Test
public void basicConstructorTest() { void basicConstructorTest() {
Stop stop = new Stop("id", "name", "indicator", 1, 2.345, 6.789); Stop stop = new Stop("id", "name", "indicator", 1, 2.345, 6.789);
assertThat(stop.getId(), is("id")); assertThat(stop.getId(), is("id"));
assertThat(stop.getName(), is("name")); assertThat(stop.getName(), is("name"));
@ -47,7 +47,7 @@ public class StopTest {
} }
@Test @Test
public void listConstructorTest() { void listConstructorTest() {
/* Create valid raw data list */ /* Create valid raw data list */
List<Serializable> raw = new ArrayList<>(); List<Serializable> raw = new ArrayList<>();
raw.add(1); raw.add(1);

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -30,13 +30,13 @@ import static org.hamcrest.core.Is.is;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
/** /**
* Unit test for the {@link Trip} meta model. * Unit test for the {@link Trip} model.
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
public class TripTest { class TripTest {
@Test @Test
public void basicConstructorTest() { void basicConstructorTest() {
Trip trip = new Trip("sid", Trip trip = new Trip("sid",
"name", "name",
"indicator", "indicator",
@ -70,7 +70,7 @@ public class TripTest {
} }
@Test @Test
public void listConstructorTest() { void listConstructorTest() {
/* Create valid raw data list */ /* Create valid raw data list */
List<Serializable> raw = new ArrayList<>(); List<Serializable> raw = new ArrayList<>();
raw.add(1); raw.add(1);

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2016-2023 Stefan Kalscheuer * Copyright 2016-2024 Stefan Kalscheuer
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -18,13 +18,12 @@ package de.stklcode.pubtrans.ura.reader;
import com.github.tomakehurst.wiremock.WireMockServer; import com.github.tomakehurst.wiremock.WireMockServer;
import com.github.tomakehurst.wiremock.client.WireMock; import com.github.tomakehurst.wiremock.client.WireMock;
import com.github.tomakehurst.wiremock.common.FileSource;
import com.github.tomakehurst.wiremock.core.WireMockConfiguration; import com.github.tomakehurst.wiremock.core.WireMockConfiguration;
import com.github.tomakehurst.wiremock.extension.Parameters; import com.github.tomakehurst.wiremock.extension.Parameters;
import com.github.tomakehurst.wiremock.extension.ResponseTransformer; import com.github.tomakehurst.wiremock.extension.ResponseTransformerV2;
import com.github.tomakehurst.wiremock.http.ChunkedDribbleDelay; import com.github.tomakehurst.wiremock.http.ChunkedDribbleDelay;
import com.github.tomakehurst.wiremock.http.Request;
import com.github.tomakehurst.wiremock.http.Response; import com.github.tomakehurst.wiremock.http.Response;
import com.github.tomakehurst.wiremock.stubbing.ServeEvent;
import de.stklcode.pubtrans.ura.UraClientConfiguration; import de.stklcode.pubtrans.ura.UraClientConfiguration;
import de.stklcode.pubtrans.ura.model.Trip; import de.stklcode.pubtrans.ura.model.Trip;
import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterAll;
@ -54,7 +53,7 @@ import static org.junit.jupiter.api.Assumptions.assumeTrue;
* *
* @author Stefan Kalscheuer * @author Stefan Kalscheuer
*/ */
public class AsyncUraTripReaderTest { class AsyncUraTripReaderTest {
private static WireMockServer httpMock; private static WireMockServer httpMock;
@BeforeAll @BeforeAll
@ -82,7 +81,7 @@ public class AsyncUraTripReaderTest {
* @throws InterruptedException Thread interrupted. * @throws InterruptedException Thread interrupted.
*/ */
@Test @Test
public void readerTest() throws InterruptedException { void readerTest() throws InterruptedException {
// Callback counter for some unhandy async mockery. // Callback counter for some unhandy async mockery.
final AtomicInteger counter = new AtomicInteger(0); final AtomicInteger counter = new AtomicInteger(0);
@ -161,7 +160,7 @@ public class AsyncUraTripReaderTest {
* @throws InterruptedException Thread interrupted. * @throws InterruptedException Thread interrupted.
*/ */
@Test @Test
public void streamClosedTest() throws InterruptedException { void streamClosedTest() throws InterruptedException {
// Callback counter for some unhandy async mockery. // Callback counter for some unhandy async mockery.
final AtomicInteger counter = new AtomicInteger(0); final AtomicInteger counter = new AtomicInteger(0);
@ -202,7 +201,7 @@ public class AsyncUraTripReaderTest {
} }
@Test @Test
public void timeoutTest() throws InterruptedException { void timeoutTest() throws InterruptedException {
// Callback counter for some unhandy async mockery. // Callback counter for some unhandy async mockery.
final AtomicInteger counter = new AtomicInteger(0); final AtomicInteger counter = new AtomicInteger(0);
@ -289,9 +288,10 @@ public class AsyncUraTripReaderTest {
); );
} }
public static class StreamTransformer extends ResponseTransformer { public static class StreamTransformer implements ResponseTransformerV2 {
@Override @Override
public Response transform(Request request, Response response, FileSource files, Parameters parameters) { public Response transform(Response response, ServeEvent serveEvent) {
Parameters parameters = serveEvent.getTransformerParameters();
int chunks = parameters.getInt("chunks", 1); int chunks = parameters.getInt("chunks", 1);
return Response.Builder.like(response) return Response.Builder.like(response)
// Read source file to response. // Read source file to response.