diff --git a/CHANGELOG.md b/CHANGELOG.md index 49f9025..320897c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ * [fix] Prevent potential NPE on SecretResponse getter * [fix] Fields of InvalidResposneException made final * [fix] Fix typo in method name `listAppRoleSecrets()` (#14) +* [fix] Removed stack traces on PUT request and response deserialization (#13) * [text] Tested against Vault 0.8.1, increased coverage ## 0.6.1 [2017-08-02] diff --git a/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleResponse.java b/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleResponse.java index 3ba51cf..9327253 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleResponse.java +++ b/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleResponse.java @@ -46,8 +46,7 @@ public final class AppRoleResponse extends VaultDataResponse { }); this.role = mapper.readValue(mapper.writeValueAsString(filteredData), AppRole.class); } catch (IOException e) { - e.printStackTrace(); - throw new InvalidResponseException(); + throw new InvalidResponseException("Failed deserializing response", e); } } diff --git a/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleSecretResponse.java b/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleSecretResponse.java index 7448a1f..5974950 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleSecretResponse.java +++ b/src/main/java/de/stklcode/jvault/connector/model/response/AppRoleSecretResponse.java @@ -46,8 +46,7 @@ public final class AppRoleSecretResponse extends VaultDataResponse { }); this.secret = mapper.readValue(mapper.writeValueAsString(filteredData), AppRoleSecret.class); } catch (IOException e) { - e.printStackTrace(); - throw new InvalidResponseException(); + throw new InvalidResponseException("Failed deserializing response", e); } } diff --git a/src/main/java/de/stklcode/jvault/connector/model/response/AuthResponse.java b/src/main/java/de/stklcode/jvault/connector/model/response/AuthResponse.java index 9e3927d..9ddd3c1 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/response/AuthResponse.java +++ b/src/main/java/de/stklcode/jvault/connector/model/response/AuthResponse.java @@ -49,8 +49,7 @@ public final class AuthResponse extends VaultDataResponse { try { this.auth = mapper.readValue(mapper.writeValueAsString(auth), AuthData.class); } catch (IOException e) { - e.printStackTrace(); - throw new InvalidResponseException(); + throw new InvalidResponseException("Failed deserializing response", e); } } diff --git a/src/main/java/de/stklcode/jvault/connector/model/response/TokenResponse.java b/src/main/java/de/stklcode/jvault/connector/model/response/TokenResponse.java index 536c5b7..5e1278b 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/response/TokenResponse.java +++ b/src/main/java/de/stklcode/jvault/connector/model/response/TokenResponse.java @@ -50,8 +50,7 @@ public final class TokenResponse extends VaultDataResponse { try { this.data = mapper.readValue(mapper.writeValueAsString(data), TokenData.class); } catch (IOException e) { - e.printStackTrace(); - throw new InvalidResponseException(); + throw new InvalidResponseException("Failed deserializing response", e); } }