From 5d46e75068557821c6352940350b13a7d10e2d2d Mon Sep 17 00:00:00 2001 From: Stefan Kalscheuer Date: Fri, 7 Apr 2017 20:57:47 +0200 Subject: [PATCH] Prevent SecretResponse from raising NPE in get() --- pom.xml | 2 +- .../connector/model/response/SecretResponse.java | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index 64d547d..f371b7c 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ de.stklcode.jvault connector - 0.5.0 + 0.5.1-SNAPSHOT jar diff --git a/src/main/java/de/stklcode/jvault/connector/model/response/SecretResponse.java b/src/main/java/de/stklcode/jvault/connector/model/response/SecretResponse.java index e534a7b..12204ba 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/response/SecretResponse.java +++ b/src/main/java/de/stklcode/jvault/connector/model/response/SecretResponse.java @@ -21,6 +21,7 @@ import com.fasterxml.jackson.databind.ObjectMapper; import de.stklcode.jvault.connector.exception.InvalidResponseException; import java.io.IOException; +import java.util.HashMap; import java.util.Map; /** @@ -45,6 +46,8 @@ public class SecretResponse extends VaultDataResponse { * @since 0.4.0 */ public Map getData() { + if (data == null) + return new HashMap<>(); return data; } @@ -56,7 +59,9 @@ public class SecretResponse extends VaultDataResponse { * @since 0.4.0 */ public Object get(String key) { - return data.get(key); + if (data == null) + return null; + return getData().get(key); } /** @@ -68,9 +73,9 @@ public class SecretResponse extends VaultDataResponse { */ @Deprecated public String getValue() { - if (data.get("value") == null) + if (get("value") == null) return null; - return data.get("value").toString(); + return get("value").toString(); } /**