diff --git a/CHANGELOG.md b/CHANGELOG.md index a82c3e8..afefe69 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## unreleased + +### Deprecations +* `AppRole.Builder#wit0hTokenPeriod()` is deprecated in favor of `#withTokenPeriod()` + ## 0.9.3 (2021-04-02) ### Improvements diff --git a/pom.xml b/pom.xml index 7917544..6da517a 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ de.stklcode.jvault jvault-connector - 0.9.3 + 0.9.4-SNAPSHOT jar diff --git a/src/main/java/de/stklcode/jvault/connector/model/AppRole.java b/src/main/java/de/stklcode/jvault/connector/model/AppRole.java index 3af63a2..f0674b9 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/AppRole.java +++ b/src/main/java/de/stklcode/jvault/connector/model/AppRole.java @@ -703,21 +703,34 @@ public final class AppRole { * @return self * @since 0.9 */ - public Builder wit0hTokenPeriod(final Integer tokenPeriod) { + public Builder withTokenPeriod(final Integer tokenPeriod) { this.tokenPeriod = tokenPeriod; return this; } + /** + * Set renewal period for generated token in seconds. + * + * @param tokenPeriod period in seconds + * @return self + * @since 0.9 + * @deprecated Use {@link #withTokenPeriod(Integer)} instead. + */ + @Deprecated + public Builder wit0hTokenPeriod(final Integer tokenPeriod) { + return withTokenPeriod(tokenPeriod); + } + /** * Set renewal period for generated token in seconds. * * @param period period in seconds * @return self - * @deprecated Use {@link #wit0hTokenPeriod(Integer)} instead. + * @deprecated Use {@link #withTokenPeriod(Integer)} instead. */ @Deprecated public Builder withPeriod(final Integer period) { - return wit0hTokenPeriod(period); + return withTokenPeriod(period); } /** diff --git a/src/main/java/de/stklcode/jvault/connector/model/AppRoleBuilder.java b/src/main/java/de/stklcode/jvault/connector/model/AppRoleBuilder.java index cb14478..e09e056 100644 --- a/src/main/java/de/stklcode/jvault/connector/model/AppRoleBuilder.java +++ b/src/main/java/de/stklcode/jvault/connector/model/AppRoleBuilder.java @@ -308,21 +308,34 @@ public final class AppRoleBuilder { * @return self * @since 0.9 */ - public AppRoleBuilder wit0hTokenPeriod(final Integer tokenPeriod) { + public AppRoleBuilder withTokenPeriod(final Integer tokenPeriod) { this.tokenPeriod = tokenPeriod; return this; } + /** + * Set renewal period for generated token in seconds. + * + * @param tokenPeriod period in seconds + * @return self + * @since 0.9 + * @deprecated Use {@link #withTokenPeriod(Integer)} instead. + */ + @Deprecated + public AppRoleBuilder wit0hTokenPeriod(final Integer tokenPeriod) { + return withTokenPeriod(tokenPeriod); + } + /** * Set renewal period for generated token in seconds. * * @param period period in seconds * @return self - * @deprecated Use {@link #wit0hTokenPeriod(Integer)} instead. + * @deprecated Use {@link #withTokenPeriod(Integer)} instead. */ @Deprecated public AppRoleBuilder withPeriod(final Integer period) { - return wit0hTokenPeriod(period); + return withTokenPeriod(period); } /** diff --git a/src/test/java/de/stklcode/jvault/connector/HTTPVaultConnectorTest.java b/src/test/java/de/stklcode/jvault/connector/HTTPVaultConnectorTest.java index 5a99b02..8b54da1 100644 --- a/src/test/java/de/stklcode/jvault/connector/HTTPVaultConnectorTest.java +++ b/src/test/java/de/stklcode/jvault/connector/HTTPVaultConnectorTest.java @@ -771,7 +771,7 @@ class HTTPVaultConnectorTest { /* Update role model with custom flags */ AppRole role2 = AppRole.builder(roleName) - .wit0hTokenPeriod(321) + .withTokenPeriod(321) .build(); /* Create role */ diff --git a/src/test/java/de/stklcode/jvault/connector/model/AppRoleBuilderTest.java b/src/test/java/de/stklcode/jvault/connector/model/AppRoleBuilderTest.java index 6c4b7c7..45e1bce 100644 --- a/src/test/java/de/stklcode/jvault/connector/model/AppRoleBuilderTest.java +++ b/src/test/java/de/stklcode/jvault/connector/model/AppRoleBuilderTest.java @@ -138,7 +138,7 @@ class AppRoleBuilderTest { .withTokenExplicitMaxTtl(TOKEN_EXPLICIT_MAX_TTL) .withTokenNoDefaultPolicy(TOKEN_NO_DEFAULT_POLICY) .withTokenNumUses(TOKEN_NUM_USES) - .wit0hTokenPeriod(TOKEN_PERIOD) + .withTokenPeriod(TOKEN_PERIOD) .withTokenType(TOKEN_TYPE) .build(); assertThat(role.getName(), is(NAME)); @@ -183,7 +183,7 @@ class AppRoleBuilderTest { .withTokenExplicitMaxTtl(TOKEN_EXPLICIT_MAX_TTL) .withTokenNoDefaultPolicy(TOKEN_NO_DEFAULT_POLICY) .withTokenNumUses(TOKEN_NUM_USES) - .wit0hTokenPeriod(TOKEN_PERIOD) + .withTokenPeriod(TOKEN_PERIOD) .withTokenType(TOKEN_TYPE) .build(); assertThat(role.getName(), is(NAME));