From d9dbdad75bd4a17562ca8c562d3adf9a8fee94d2 Mon Sep 17 00:00:00 2001 From: Stefan Kalscheuer Date: Tue, 13 Jun 2023 18:47:11 +0200 Subject: [PATCH] use explicit utf-8 encoding for parsing responses --- CHANGELOG.md | 3 +++ .../de/stklcode/jvault/connector/internal/RequestHelper.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b6330f3..54ecb47 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ ## unreleased +### Improvements +* Use explicit UTF-8 encoding for parsing responses + ### Dependencies * Updated Jackson to 2.15.2 diff --git a/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java b/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java index 84428c5..ee3d0fc 100644 --- a/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java +++ b/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java @@ -399,7 +399,7 @@ public final class RequestHelper implements Serializable { * @throws InvalidResponseException on reading errors */ private String handleResult(final HttpResponse response) throws InvalidResponseException { - try (var reader = new BufferedReader(new InputStreamReader(response.body()))) { + try (var reader = new BufferedReader(new InputStreamReader(response.body(), UTF_8))) { return reader.lines().collect(Collectors.joining("\n")); } catch (IOException ignored) { throw new InvalidResponseException(Error.READ_RESPONSE, 200); @@ -414,7 +414,7 @@ public final class RequestHelper implements Serializable { */ private void handleError(final HttpResponse response) throws VaultConnectorException { if (response.body() != null) { - try (var reader = new BufferedReader(new InputStreamReader(response.body()))) { + try (var reader = new BufferedReader(new InputStreamReader(response.body(), UTF_8))) { var responseString = reader.lines().collect(Collectors.joining("\n")); ErrorResponse er = jsonMapper.readValue(responseString, ErrorResponse.class); /* Check for "permission denied" response */