diff --git a/CHANGELOG.md b/CHANGELOG.md index 19d15d5..80b135c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## unreleased + +### Fixes +* Only initialize custom trust managers, if CA certificate is actually provided (#43) + ## 0.9.1 (2021-01-03) ### Improvements diff --git a/pom.xml b/pom.xml index 58b5740..f32d020 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ de.stklcode.jvault jvault-connector - 0.9.1 + 0.9.2-SNAPSHOT jar diff --git a/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java b/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java index 00b5f1b..b4b7376 100644 --- a/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java +++ b/src/main/java/de/stklcode/jvault/connector/internal/RequestHelper.java @@ -367,18 +367,22 @@ public final class RequestHelper implements Serializable { */ private SSLConnectionSocketFactory createSSLSocketFactory() throws TlsException { try { - // Create Keystore with trusted certificate. - KeyStore keyStore = KeyStore.getInstance(KeyStore.getDefaultType()); - keyStore.load(null, null); - keyStore.setCertificateEntry("trustedCert", trustedCaCert); - - // Initialize TrustManager. - TrustManagerFactory tmf = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); - tmf.init(keyStore); - - // Create context using this TrustManager. + // Create context.. SSLContext context = SSLContext.getInstance(tlsVersion); - context.init(null, tmf.getTrustManagers(), new SecureRandom()); + + if (trustedCaCert != null) { + // Create Keystore with trusted certificate. + KeyStore keyStore = KeyStore.getInstance(KeyStore.getDefaultType()); + keyStore.load(null, null); + keyStore.setCertificateEntry("trustedCert", trustedCaCert); + + // Initialize TrustManager. + TrustManagerFactory tmf = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); + tmf.init(keyStore); + context.init(null, tmf.getTrustManagers(), null); + } else { + context.init(null, null, null); + } return new SSLConnectionSocketFactory( context,