From f27d90eb8f3860a4ddb770f648c7dd02a90e48a5 Mon Sep 17 00:00:00 2001
From: Stefan Kalscheuer <stefan@stklcode.de>
Date: Wed, 13 Aug 2025 12:08:06 +0200
Subject: [PATCH] make uninstall hook more robust against unexpected return
 values

---
 includes/class-system.php | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/includes/class-system.php b/includes/class-system.php
index 807fab4..83c76ac 100644
--- a/includes/class-system.php
+++ b/includes/class-system.php
@@ -9,6 +9,7 @@
 
 namespace SCLiveticker;
 
+use WP_Post;
 use WP_Query;
 
 // Exit if accessed directly.
@@ -53,7 +54,11 @@ class System extends SCLiveticker {
 		// Delete all ticks.
 		$ticks = new WP_Query( array( 'post_type' => 'scliveticker_tick' ) );
 		foreach ( $ticks->get_posts() as $tick ) {
-			wp_delete_post( $tick->ID, true );
+			if ( $tick instanceof WP_Post ) {
+				wp_delete_post( $tick->ID, true );
+			} else {
+				wp_delete_post( $tick, true );
+			}
 		}
 
 		// Temporarily register taxonomy to delete it.
@@ -66,8 +71,10 @@ class System extends SCLiveticker {
 				'hide_empty' => false,
 			)
 		);
-		foreach ( $tickers as $ticker ) {
-			wp_delete_term( $ticker->term_id, 'scliveticker_ticker' );
+		if ( ! is_wp_error( $tickers ) ) {
+			foreach ( $tickers as $ticker ) {
+				wp_delete_term( $ticker->term_id, 'scliveticker_ticker' );
+			}
 		}
 
 		// Unregister taxonomy again.